lkml.org 
[lkml]   [2011]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/7] allow killing tasks in your own or child userns
Quoting Bastian Blank (bastian@waldi.eu.org):
> On Mon, Jan 10, 2011 at 04:51:51PM -0600, Serge Hallyn wrote:
> > Quoting Bastian Blank (bastian@waldi.eu.org):
> > > Isn't that equal to this?
> > >
> > > if (ns_capable(tcred->user->user_ns, CAP_KILL))
> > > return 1;
> > >
> > > if (cred->user->user_ns == tcred->user->user_ns &&
> > > (cred->euid == tcred->suid ||
> > > cred->euid == tcred->uid ||
> > > cred->uid == tcred->suid ||
> > > cred->uid == tcred->uid))
> > > return 1;
> > >
> > > return 0;
> > >
> > > I would consider this much easier to read.
> >
> > Unfortunately, it's actually not equivalent. when capable()
> > returns success, then it sets the current->flags |= PF_SUPERPRIV.
> > If permission is granted based on userids and the capability
> > isn't needed, then we don't want to needlessly set PF_SUPERPRIV.
>
> Well, then switch the two if-clauses.

hup, will do, much nicer, thanks.

> What is this flag used for anyway? I only see it used in the accounting
> stuff, and if every user can get it, it is not longer useful.

hm, I'm not sure... maybe noone is using it!


\
 
 \ /
  Last update: 2011-01-11 02:33    [W:0.098 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site