lkml.org 
[lkml]   [2011]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCHv1 01/12] unicore32 core architecture: build infrastructure
    Date


    > -----Original Message-----
    > From: Sam Ravnborg [mailto:sam@ravnborg.org]
    > Sent: Saturday, January 08, 2011 7:48 PM
    > To: Guan Xuetao
    > Cc: 'Paul Mundt'; linux-arch@vger.kernel.org; linux-kernel@vger.kernel.org
    > Subject: Re: [PATCHv1 01/12] unicore32 core architecture: build infrastructure
    >
    > > > > +textofs-y := 0x00408000
    > > > > +
    > > > > +# The byte offset of the kernel image in RAM from the start of RAM.
    > > > > +TEXT_OFFSET := $(textofs-y)
    > > >
    > > > If you are going to have different TEXT_OFFSET's then I suggest to move
    > > > this to KConfig as an "hex "Text offset" config option.
    > > > You can set default values dependign on BSP etc.
    > > There is no different TEXT_OFFSET.
    > >
    > > >
    > > > Also defiing stuff here just to export it for use in boot/
    > > > has always looked like a strange concept - but many archs do so today.
    > > > You do not export TEXT_OFFSET but I guess this is a bug?
    > > I need TEXT_OFFSET for kernel/ and boot/, so export it.
    >
    > I would suggest to move this to you Kconfig file.
    > something like this:
    >
    > # The byte offset of the kernel image in RAM from the start of RAM
    > config UNICORE32_TEXT_OFFSET
    > hex
    > default 0x00408000
    >
    > Then you have the symbol available as CONFIG_UNICORE32_TEXT_OFFSET
    > both in your Makefiles and in your source files.
    Thanks.
    Because TEXT_OFFSET is not changed in different machines or in configuration time,
    I move it into mach-spec memory.h and rename it KERNEL_IMAGE_START.

    Guan Xuetao



    \
     
     \ /
      Last update: 2011-01-10 14:11    [W:0.037 / U:92.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site