Messages in this thread Patch in this message | | | Date | Sat, 01 Jan 2011 16:49:22 +0100 | From | roel kluin <> | Subject | [PATCH] speakup: &&/|| confusion in silent_store() |
| |
Fix test: the branch is always taken.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- drivers/staging/speakup/kobjects.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index cc79f9e..a082f8d 100644 --- a/drivers/staging/speakup/kobjects.c +++ b/drivers/staging/speakup/kobjects.c @@ -332,7 +332,7 @@ static ssize_t silent_store(struct kobject *kobj, struct kobj_attribute *attr, unsigned long flags; len = strlen(buf); - if (len > 0 || len < 3) { + if (len > 0 && len < 3) { ch = buf[0]; if (ch == '\n') ch = '0';
| |