Messages in this thread | | | Date | Sat, 01 Jan 2011 06:53:34 -0800 | From | "Justin P. Mattock" <> | Subject | Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable. |
| |
On 01/01/2011 01:09 AM, Dan Carpenter wrote: > On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote: >> On 12/31/2010 10:48 PM, Finn Thain wrote: >>>> -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ >>>> +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ >>> >>> I think, "other values disable" was what you meant? >>> >>> Finn >>> >>>> #define EEPROM_SW_AD_MASK 0x0300 >>>> #define EEPROM_SW_AD_ENABLE 0x0100 >>>> >>>> >>> >> >> no! I changed it to disabled to make it proper.. > > Finn is obviously right, but maybe a compromise would be: > > Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean > "disable". > > regards, > dan carpenter >
ahh.. I see what you your saying now.. alright let me send this out that way..
Justin P. Mattock
| |