Messages in this thread Patch in this message | | | Subject | [PATCH] scripts/checkpatch.pl: Add warnings for static char that could be static const char | From | Joe Perches <> | Date | Thu, 09 Sep 2010 12:21:46 -0700 |
| |
Add warnings for possible missing const uses of static char foo[] = "bar" that could be static const char foo[] = "bar" and static const char *foo[] = {"bar", "baz"} that could be static const char * const foo[] = {"bar", "baz"}
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2039acd..8df382b 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1806,6 +1806,18 @@ sub process { $herecurr); } +# check for static const char * arrays. + if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) { + WARN("static const char * array should probably be static const char * const\n" . + $herecurr); + } + +# check for static char foo[] = "bar" declarations. + if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) { + WARN("static char array declaration should probably be static const char\n" . + $herecurr); + } + # check for new typedefs, only function parameters and sparse annotations # make sense. if ($line =~ /\btypedef\s/ &&
| |