Messages in this thread | | | Date | Wed, 8 Sep 2010 12:14:05 +0300 | Subject | Re: [PATCHv6 3/3] mmc_test: collect data and show it via sysfs by demand | From | Andy Shevchenko <> |
| |
On Wed, Sep 8, 2010 at 1:58 AM, Chris Ball <cjb@laptop.org> wrote: > Hoping Andy doesn't mind me jumping in, here's an attempt at a better > changelog: Thanks. I will take into account this.
> Prior to this patch, the "test" file under each card's sysfs node was > write-only, and results were obtained by looking at dmesg. This patch > improves programmatic access to the test results, making them available > by reading back from the same "test" file: > > [root@host mmc0:e624]# echo 6 > test > [root@host mmc0:e624]# cat test > Test 6: 2 It even better to get this sample for performance tests as well.
> I think we should do this by modifying the Kconfig text as well: At least. And add documentation and link to it in Kconfig.
> Separately, Andy, I think we should translate the general result return > code for the user, i.e. print OK/FAIL/UNSUP_HOST/UNSUP_CARD for return > values 0-3. Would you mind adding that? (Unfortunately, it invalidates > the usage example I just gave above, so that should change too..) I thought about it. But for the scripts may be better to keep numeric value as well. I will think again hot to implement better.
Thanks.
-- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |