lkml.org 
[lkml]   [2010]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] spi/spi_s3c64xx: Move to subsys_initcall()
    From
    On Tue, Sep 7, 2010 at 7:29 PM, Mark Brown
    <broonie@opensource.wolfsonmicro.com> wrote:
    > Allow the use of the S3C64xx SPI controller with things like PMICs by
    > moving the init up to subsys_initcall().
    >
    > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    > ---
    >
    > Incidentally I don't seem to see anything in the current SPI tree for
    > -next - should the tree being used be updated or something?
    >
    >  drivers/spi/spi_s3c64xx.c |    2 +-
    >  1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
    > index f72e1c0..6e48ea9 100644
    > --- a/drivers/spi/spi_s3c64xx.c
    > +++ b/drivers/spi/spi_s3c64xx.c
    > @@ -1181,7 +1181,7 @@ static int __init s3c64xx_spi_init(void)
    >  {
    >        return platform_driver_probe(&s3c64xx_spi_driver, s3c64xx_spi_probe);
    >  }
    > -module_init(s3c64xx_spi_init);
    > +subsys_initcall(s3c64xx_spi_init);

    Couldn't any user ever need to load it as a module?
    If no, we might as well drop the s3c64xx_spi_exit and s3c64xx_spi_remove
    as well and save space. Rather going a step further, shouldn't then all
    spi drivers be that way? Two steps further, why not every 'bus-driver' ?
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-09-08 06:59    [W:0.052 / U:61.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site