Messages in this thread | | | Date | Wed, 8 Sep 2010 12:23:01 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 1/3] [BUGFIX] memory hotplug: fix next block calculation in is_removable |
| |
On Tue, Sep 07, 2010 at 10:32:44AM +0900, KAMEZAWA Hiroyuki wrote: > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > next_active_pageblock() is for finding next _used_ freeblock. It skips > several blocks when it finds there are a chunk of free pages lager than > pageblock. But it has 2 bugs. > > 1. We have no lock. page_order(page) - pageblock_order can be minus. > 2. pageblocks_stride += is wrong. it should skip page_order(p) of pages. > > Changelog: 2010/09/07 > - fix range check of order returned by page_order(). > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Mel Gorman <mel@csn.ul.ie>
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |