lkml.org 
[lkml]   [2010]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: wake up reading tasks when debug event occurs
On Mon, 30 Aug 2010, Chase Douglas wrote:

> From: Chase Douglas <chase.douglas@ubuntu.com>
>
> Some devices poke the hid core in a way that causes hid_debug_event to
> be called, while never calling hid_dump_input. Without this wakeup
> addition, tasks reading for hid events through debugfs may never see any
> events. It may be that a well written driver doesn't cause this, but
> then what's the point of debugfs?

Well the main reason for the debugfs interface has been to debug strange
devices. But your fix is a clear improvement for pathological cases, which
is OK for debugging interface.

Applied, thanks.

>
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> ---
> drivers/hid/hid-debug.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index 850d02a..adff4ef 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -570,6 +570,8 @@ void hid_debug_event(struct hid_device *hdev, char *buf)
> buf[i];
> list->tail = (list->tail + i) % HID_DEBUG_BUFSIZE;
> }
> +
> + wake_up_interruptible(&hdev->debug_wait);
> }
> EXPORT_SYMBOL_GPL(hid_debug_event);
>
> --
> 1.7.1
>

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2010-09-08 12:05    [W:2.954 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site