lkml.org 
[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/14] staging: westbridge: improve error path
On Tue, Sep 07, 2010 at 09:16:46AM +0200, walter harms wrote:
>
>
> Greg KH schrieb:
> > On Mon, Sep 06, 2010 at 09:51:20AM +0200, walter harms wrote:
> >> the indention should be fixed also.
> >
> > Yes, the indentation for the whole file should be fixed, but that's not
> > what this patch was doing.
> >
> > Remember, a patch should only do one thing at a time.
> >
>
> that is true,
> but in this special case i nearly missed the #if because it is so hidden
> in the code. IMHO that is enough for an exception.

This whole driver needs major help. But again, one thing at a time
please.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-09-08 02:29    [W:0.048 / U:2.904 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site