lkml.org 
[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] identify firmware version
On 09/07/2010 01:32 AM, Rafi Rubin wrote:
> On Mon, Sep 06, 2010 at 11:22:50PM +0200, Jiri Slaby wrote:
>>>> +
>>>> + ret = ntrig_version_string(&data[2], buf);
>>>> +
>>>> + dev_info(&hdev->dev,
>>>> + "Firmware version: %s (%02x%02x %02x%02x)\n",
>>>> + buf, data[2], data[3], data[4], data[5]);
>>>> +
>>>> + kfree(buff);
>>
>> In any case, this doesn't compile...
>>
>>>> + }
>
> Jiri, I moved the code to a separate function as Dmitry suggested, and compiled a kernel from a clean tree using
> gcc-3.4 (I think).

This version is OK. In the previous one, there was
char *buf;
...
kfree(buff);

thanks,
--
js


\
 
 \ /
  Last update: 2010-09-07 08:57    [W:0.102 / U:18.460 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site