lkml.org 
[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: checkpatch problem
On Tue, Sep 07, 2010 at 02:09:42PM +0100, David Howells wrote:
>
> Hi,
>
> Checkpatch generates the following messages for inline asm strings:
>
> WARNING: unnecessary whitespace before a quoted newline
> #49: FILE: arch/m32r/include/asm/irqflags.h:31:
> + "ld24 %0, #0 ; Use 32-bit insn. \n\t"
>
> however, inline asm is more readable if I can tabulate things, including the
> newline markers:
>
> asm volatile (
> "ld24 %0, #0 ; Use 32-bit insn. \n\t"
> "mvfc %1, psw ; No interrupt can be accepted here. \n\t"
> "mvtc %0, psw \n\t"
> "and3 %0, %1, #0xffbf \n\t"
> "mvtc %0, psw \n\t"
> : "=&r" (tmpreg0), "=&r" (tmpreg1)
> :
> : "cbit", "memory");
>
> Can you please fix it, even if it's only to permit multiple TAB chars before
> '\n'.
>
> Whilst this check is probaly fine for strings to be displayed in some way, this
> doesn't necessarily apply to inline asm strings. Furthermore, the extra white
> space does not impact the resulting binary.

A tricky one to know how to detect it as different. Often we do not
have the asm markers to hint us to change style. This affects us often
as gcc abuses the meaning of almost every character and has different
spacing for them too.

Will think on it.

-apw


\
 
 \ /
  Last update: 2010-09-07 20:03    [W:0.078 / U:3.280 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site