lkml.org 
[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC] Fix typos
On 09/02/2010 02:18 PM, Randy Dunlap wrote:
> On Thu, 2 Sep 2010 16:05:14 -0300 Lucas De Marchi wrote:
>
>> Hi,
>>
>> I'd like to know if it's worth fixing all typos found in comments,
>> documentation and sometimes code. A first attempt to do that you can
>> find at http://people.profusion.mobi/~lucas/kernel-typos-fix.patch
>>
>> This was done by using the list of common typos available at
>> http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings
>>
>> I already removed some false positives, but there are more. Before
>> going ahead and verifying all of them, I'd like to know whether this
>> would be a good patch.
>
> Hi,
>
> I'd take most of the corrections in Documentation/, but in general,
> I don't think that it's a good idea without some careful review.

I am in agreement with Randy on his point that any changes should get
reviewed if possible by the people who own the files or authored the
comments.

I reviewed all the pieces that were kdb / kgdb related which include
the following and all the changes are ok (one exception noted).

Documentation/kernel-parameters.txt
arch/cris/arch-v32/kernel/kgdb.c
drivers/misc/kgdbts.c
kernel/debug/kdb/kdb_main.c
kernel/debug/kdb/kdb_support.c

--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -277,7 +277,7 @@ static int hw_break_release_slot(int breakno)
pevent = per_cpu_ptr(breakinfo[breakno].pev, cpu);
if (dbg_release_bp_slot(*pevent))
/*
- * The debugger is responisble for handing the retry on
+ * The debugger is responsible for handing the retry on

---- from Jason ----

This should actually be:
+ * The debugger is responsible for handling the retry on

--------------------
Thanks,
Jason.


\
 
 \ /
  Last update: 2010-09-07 19:33    [W:0.079 / U:24.016 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site