[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 09/10] VFS: Remove read-only checks from dentry_permission
    On Mon, 2010-09-06 at 10:50 +1000, NeilBrown wrote:
    > It is not sufficient to depend on the the "filesystem is readonly"
    > tests in dentry_permission as it does not check if the vfsmnt is
    > readonly.
    > All call sites already call mnt_want_write or __mnt_is_readonly which
    > includes the test on MS_RDONLY.
    > So remove this test from dentry_permission as it simply duplicates
    > tests done elsewhere.

    Yeah, I remember auditing all of the dentry_permission() callers and
    moving them over to mnt_want_write() and friends as well. I don't quite
    remember why we didn't take this step back then, but it looks sane to

    -- Dave

     \ /
      Last update: 2010-09-07 18:01    [W:0.020 / U:1.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site