lkml.org 
[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] Staging: otus: added valid KERN_ loglevels to printk in wwrap.c
From
Date
On Tue, 2010-09-07 at 18:44 +0530, Prashant P. Shah wrote:
> This is a patch to the wwrap.c file that adds valid KERN_ loglevels
> to printk() statements
>
> Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
> ---
> drivers/staging/otus/wwrap.c | 33 ++++++++++++++++-----------------
> 1 files changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
[]
> @@ -358,13 +357,13 @@ void zfLnxUsbDataIn_callback(urb_t *urb)
> #if 0
> /* Dump data */
> for (ii = index; ii < pkt_len+4;) {
> - printk("%02x ", (buf->data[ii] & 0xff));
> + printk(KERN_INFO "%02x ", (buf->data[ii] & 0xff));
>
> if ((++ii % 16) == 0)
> - printk("\n");
> + printk(KERN_INFO "\n");
> }
>
> - printk("\n");
> + printk(KERN_INFO "\n");
> #endif
>
> pad_len = 4 - (pkt_len & 0x3);

and

> @@ -636,11 +635,11 @@ u32_t zfLnxUsbSubmitTxData(zdev_t *dev)
> if (TxData->hdrlen != 0) {
> puTxBuf = macp->txUsbBuf[freeTxUrb];
> for (i = 0; i < len; i++) {
> - printk("%02x ", puTxBuf[i]);
> + printk(KERN_INFO "%02x ", puTxBuf[i]);
> if (i % 16 == 15)
> - printk("\n");
> + printk(KERN_INFO "\n");
> }
> - printk("\n");
> + printk(KERN_INFO "\n");

These should use KERN_CONT.

It'd be better to use print_hex_dump() instead.




\
 
 \ /
  Last update: 2010-09-07 17:13    [W:0.039 / U:21.920 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site