lkml.org 
[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: disabling group leader perf_event
From
Date
On Tue, 2010-09-07 at 08:53 -0400, Steven Rostedt wrote:
> On Mon, 2010-09-06 at 11:42 -0500, Tom Zanussi wrote:
> > Hi,
> >
> > On Mon, 2010-09-06 at 09:16 -0400, Steven Rostedt wrote:
> > > Sorry for top post, sending via my android phone. Today's a US holiday.
> > >
> > >
> > > We can filter before the work, if we expose the parameters. Currently we filter what goes into the buffer and there are several cases where we don't know the result before the work.
> > >
> > > If we also expose the parameters of a TRACE_EVENT, then we can filter on them before the work.
> >
> > I'm not sure exactly what you mean by exposing the parameters, but yeah,
> > in general it should be possible to filter on any field you can get the
> > address of, before you ever allocate space for the event or assign the
> > field to it.
> >
> > In the cases where you don't know the result until you do the work, such
> > as for example this from kvm_age_page tracepoint:
> >
> > TP_fast_assign(
> > __entry->hva = hva;
> > __entry->gfn =
> > slot->base_gfn + ((hva - slot->userspace_addr) >>
> > PAGE_SHIFT);
> > __entry->referenced = ref;
> > ),
> >
> > I guess you'd want the macro to assign the result to a temporary in
> > order to be able to participate in the filtering, or did you have
> > something else in mind?
>
> Here we already did the work. We assigned everything, then might as well
> keep what we have. What I had in mind was:
>
> TRACE_EVENT(kvm_age_page,
> TP_PROTO(ulong hva, struct kvm_memory_slot *slot, int ref),
> TP_ARGS(hva, slot, ref),
>
> and be able to make a filter that says: slot->userspace_addr > X
>
> Where we filter the parameters and not what is in the entry.
> Unfortunately, this would make TRACE_EVENT() even bigger since we would
> need to store what the parameter names are.
>

Yeah, that would be nice to be able to do someday, with the full-fledged
interpreter being discussed; I was thinking for now of only the minimal
set of changes to the current filtering code needed to do the filtering
before the events hit the buffer, in which case I think for complex
expressions like this, you have to do the work of evaluating the full
expression before using the end result in a filter.

Tom

> -- Steve
>
>
>
>




\
 
 \ /
  Last update: 2010-09-07 16:19    [W:0.056 / U:0.796 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site