lkml.org 
[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] USB: Fix kernel oops with g_ether and Windows
Maxim Osipov wrote:
> On Tue, Sep 7, 2010 at 1:55 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> >
> >   It was caught by me on the list too, right at the same day the patch was
> > posted. The author remained silent though...
> >

Sorry Sergei, I seem to have missed your mail on the list, and didn't
bother hunting in the list archives.

>
> Sorry for being silent - I had lots of things to do. Regarding the
> patch itself - I respect kernel coding conventions, but I think it is
> bad to have two different code styles in one file. Note, this is my
> personal opinion only.
>

I should have looked closer - I see now that you've only retained
the existing style.

Since Greg has already sent a pull request, I won't touch the file
now; maybe a trivial patch later on to fix up the coding style.

- Anand
\
 
 \ /
  Last update: 2010-09-07 12:51    [W:0.045 / U:6.388 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site