Messages in this thread | | | Date | Mon, 6 Sep 2010 20:58:03 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v3] scsi_debug: Convert to use root_device_register() and root_device_unregister() |
| |
On Mon, Sep 06, 2010 at 11:00:56PM -0400, James Bottomley wrote: > On Mon, 2010-09-06 at 17:32 -0700, Dmitry Torokhov wrote: > > On Mon, Sep 06, 2010 at 05:24:28PM -0700, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab@linux-iscsi.org> > > > > > > Hi Doug and Co, > > > > > > This patch updates the scsi_debug virtual LLD to use root_device_register() > > > and root_device_unregister() from include/linux/device.h instead of device_register() > > > and device_unregister() respectively within scsi_debug_init() and scsi_debug_exit() > > > This simply involved converting the static struct device pseudo_primary into a > > > pointer that is setup by the call to root_device_register(). > > > > > > This patch also contains the correct IS_ERR() conditional check of > > > root_device_register() from within scsi_debug_init(). > > > > > > Thanks to Richard Sharpe and Dmitry Torokhov for their help with this item. > > > > > > Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org> > > > > Thanks for making the changes. > > > > Acked-by: Dmitry Torokhov <dtor@mail.ru> > > Can I make that Reviewed-by:? Acked-by is really just for maintainer > patches which don't warrant a signoff. >
Sure, whatever suits better.
-- Dmitry
| |