Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 2/4] swap: prevent reuse during hibernation | Date | Mon, 6 Sep 2010 20:34:36 +0200 |
| |
On Monday, September 06, 2010, KAMEZAWA Hiroyuki wrote: > On Mon, 6 Sep 2010 01:12:38 -0700 (PDT) > Hugh Dickins <hughd@google.com> wrote: > > > Move the hibernation check from scan_swap_map() into try_to_free_swap(): > > to catch not only the common case when hibernation's allocation itself > > triggers swap reuse, but also the less likely case when concurrent page > > reclaim (shrink_page_list) might happen to try_to_free_swap from a page. > > > > Hibernation already clears __GFP_IO from the gfp_allowed_mask, to stop > > reclaim from going to swap: check that to prevent swap reuse too. > > > > Signed-off-by: Hugh Dickins <hughd@google.com> > > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > Cc: "Rafael J. Wysocki" <rjw@sisk.pl> > > Cc: Ondrej Zary <linux@rainbow-software.org> > > Cc: Andrea Gelmini <andrea.gelmini@gmail.com> > > Cc: Balbir Singh <balbir@in.ibm.com> > > Cc: Andrea Arcangeli <aarcange@redhat.com> > > Cc: Nigel Cunningham <nigel@tuxonice.net> > > Cc: stable@kernel.org > > Hmm...seems better. > > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
| |