lkml.org 
[lkml]   [2010]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/8] drivers/i2c/busses/i2c-pasemi.c: Fix unsigned return type
    On Sun, Sep 05, 2010 at 09:00:22PM +0200, Julia Lawall wrote:
    > The function has an unsigned return type, but returns a negative constant
    > to indicate an error condition. The result of calling the function is
    > always stored in a variable of type (signed) int, and thus unsigned can be
    > dropped from the return type.
    >
    > A sematic match that finds this problem is as follows:
    > (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @exists@
    > identifier f;
    > constant C;
    > @@
    >
    > unsigned f(...)
    > { <+...
    > * return -C;
    > ...+> }
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <julia@diku.dk>

    Acked-by: Olof Johansson <olof@lixom.net>



    \
     
     \ /
      Last update: 2010-09-06 18:33    [W:0.020 / U:1.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site