lkml.org 
[lkml]   [2010]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC 22/22] tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module
From
On Mon, Sep 6, 2010 at 7:48 AM, Richard Sharpe
<realrichardsharpe@gmail.com> wrote:
>> I think what you need is root_device_create() which will allocate a
>> device structure and assign ->release() that is implemented outside of
>> your module. This way your module may be unloaded even if there are
>> outstanding references to tcm_loop_primary device.
>
> I am embarrassed to admit that scst_local (or whatever its new name
> will be) probably has the same fault, as it too was based on
> scsi_debug ...
>
> However, I did a search of the 2.6.24.1 source tree and could not find

Typo alert: 2.6.34.1!

> any instances of root_device_create() being called nor defined. I just
> double and triple checked the spelling.
>
> Ahhh, I see why. A slightly different search suggests that it is
> root_device_register(const char *name).
>
> From include/linux/device.h:
>
> static inline struct device *root_device_register(const char *name)
> {
>        return __root_device_register(name, THIS_MODULE);
> }
>
> Was that the one you were thinking of?
>
>> The rest of devices you create needs to increment module counter or
>> otherwise ensure that their methods stay available until they are
>> cleaned up (->release() is called).
>
> OK, I need to check out how this is done.
>
>> Hope this helps.
>
> Sure does.
>
> --
> Regards,
> Richard Sharpe
>



--
Regards,
Richard Sharpe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-09-06 17:11    [W:0.064 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site