lkml.org 
[lkml]   [2010]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 10/14] hppfs: check for IS_ERR() instead of != NULL
Date
From: Vasiliy Kulikov <segooon@gmail.com>

Function get_inode may return ERR_PTR(...). Check for it.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
fs/hppfs/hppfs.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/hppfs/hppfs.c b/fs/hppfs/hppfs.c
index 7b02772..e7d6535 100644
--- a/fs/hppfs/hppfs.c
+++ b/fs/hppfs/hppfs.c
@@ -173,7 +173,7 @@ static struct dentry *hppfs_lookup(struct inode *ino, struct dentry *dentry,

err = -ENOMEM;
inode = get_inode(ino->i_sb, proc_dentry);
- if (!inode)
+ if (IS_ERR_OR_NULL(inode))
goto out_dput;

d_add(dentry, inode);
@@ -730,7 +730,7 @@ static int hppfs_fill_super(struct super_block *sb, void *d, int silent)

err = -ENOMEM;
root_inode = get_inode(sb, proc_mnt->mnt_sb->s_root);
- if (!root_inode)
+ if (IS_ERR_OR_NULL(root_inode))
goto out_mntput;

sb->s_root = d_alloc_root(root_inode);
--
1.7.0.4


\
 
 \ /
  Last update: 2010-09-05 20:37    [from the cache]
©2003-2011 Jasper Spaans