Messages in this thread | | | Date | Sat, 04 Sep 2010 14:59:54 +0200 | From | Jiri Slaby <> | Subject | bna: potential null dereference |
| |
Hi,
stanse found a potential null dereference: bnad_cb_tx_cleanup -> struct bnad_unmap_q *unmap_q = tcb->unmap_q; -> -- tcb cannot be null now -- -> if (!tcb || (!tcb->unmap_q))
The thing is I have no idea whether the second parameter of cleanup may be null (move assignment after the check) or not (remove the check)
Could you fix that?
thanks, -- js
| |