Messages in this thread | | | From | Chris Ball <> | Subject | Re: HIDDEV: potential NULL dereference | Date | Sat, 04 Sep 2010 12:39:27 -0400 |
| |
Hi Jiri,
> If hid was ever NULL at this phase, the check couldn't improve > anything due to hid->driver_data dereference being still before > the check. So again my question, how this could change anything? > > Above that, it just makes the window shorter, but the bug is > still there, isn't it? Is the following scenario reasonable?
You're right -- I'd missed the other dereference, sorry. It's surprising that we have two reports from users saying that the patch got rid of a reproducible oops for them.
Dan Carpenter has commented on this too: http://www.spinics.net/lists/linux-input/msg10541.html
As he says, it looks like the code's overdue for some real locking.
Thanks,
- Chris. -- Chris Ball <cjb@laptop.org> One Laptop Per Child
| |