Messages in this thread Patch in this message | | | Subject | [PATCH] regulator: ab8500 - fix off-by-one value range checking for selector | From | Axel Lin <> | Date | Sat, 04 Sep 2010 23:06:41 +0800 |
| |
selector is used as array index of info->supported_voltages Thus the valid value range should be 0 .. info->voltages_len -1
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/regulator/ab8500.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c index 3d09580..28c7ae6 100644 --- a/drivers/regulator/ab8500.c +++ b/drivers/regulator/ab8500.c @@ -157,7 +157,7 @@ static int ab8500_list_voltage(struct regulator_dev *rdev, unsigned selector) if (info->fixed_uV) return info->fixed_uV; - if (selector > info->voltages_len) + if (selector >= info->voltages_len) return -EINVAL; return info->supported_voltages[selector]; -- 1.7.2
| |