lkml.org 
[lkml]   [2010]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/5] irq: add tracepoint to softirq_raise
On Fri, Sep 03, 2010 at 11:39:36AM -0400, Steven Rostedt wrote:
> On Fri, 2010-09-03 at 17:29 +0200, Frederic Weisbecker wrote:
>
> > > #define softirq_name(sirq) { sirq##_SOFTIRQ, #sirq }
> > > #define show_softirq_name(val) \
> > > @@ -93,7 +95,10 @@ DECLARE_EVENT_CLASS(softirq,
> > > ),
> > >
> > > TP_fast_assign(
> > > - __entry->vec = (int)(h - vec);
> > > + if (vec)
> > > + __entry->vec = (int)(h - vec);
> > > + else
> > > + __entry->vec = *((int *)h);
> > > ),
> >
> >
> >
> > It seems that this will break softirq_entry/exit tracepoints.
> > __entry->vec will deref vec->action() for these two, which is not
> > what we want.
>
> But for trace_softirq_entry and trace_softirq_exit, vec will not be
> NULL.


Oh right...

/me slaps his forehead



>
> >
> > If you can't have the same tracepoint signature for the three, just
> > split the new one in a seperate TRACE_EVENT().
>
> It may be a bit of a hack, and questionable about adding another
> TRACE_EVENT(). There still is a pretty good space savings in using
> DEFINE_EVENT() over TRACE_EVENT() though.


Yeah, let's keep it as is.



\
 
 \ /
  Last update: 2010-09-03 17:45    [W:0.096 / U:0.636 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site