Messages in this thread | | | Date | Fri, 03 Sep 2010 14:59:29 +0200 | From | Henrik Rydberg <> | Subject | Re: [PATCH 5/5] input: wacom: Add a quirk for lowres Bamboo devices |
| |
On 09/03/2010 02:47 PM, Ping Cheng wrote: [...] > + /* quirks for bamboo touch */
> + if (features->x_max == 480 && features->y_max == 320) { > > A check on all Bamboo touch devices can be a generic way to cover all > Bamboos with touch feature (4 models). This check can be based on the > product id or features->type (== BAMBOO_PT) in combination with the > actual type (pen/touch) of the device. All Bamboo touch devices use the > same protocol.
I guess the only one who knows if there will be other resolutions reported for BAMBOO_PT is you. :-) I wanted to not break any eventual resolution improvements in the BAMBOO_PT family, but if you say there aren't any, using the BAMBOO_PT check will be better, as you say.
> + features->x_max = 15360; > + features->y_max = 10240; > > I guess these two numbers rely on the original maxes: (480, 320). If so, > can we also make them generic by accessing features->x_max/y_max > directly?
If you mean something like "features->x_max <<= 5", absolutely. Again, this all depends on what resolutions are to be anticipated, and which ones should be scaled this way.
Henrik
| |