Messages in this thread | | | Date | Tue, 28 Sep 2010 15:01:26 -0400 | From | Jarod Wilson <> | Subject | Re: [PATCH] staging: crystalhd: fix signed bug |
| |
On Sun, Sep 12, 2010 at 10:56:51PM +0400, Vasiliy Kulikov wrote: > chd_dec_major is unsigned, so check chd_dec_major < 0 doesn't make sense. > Since it is used as signed, declare it as int. > > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Indeed, Bad Things here when we try to store the ret from register_chrdev in an unsigned int and test it for < 0...
Acked-by: Jarod Wilson <jarod@redhat.com>
-- Jarod Wilson jarod@redhat.com
| |