Messages in this thread | | | Date | Tue, 28 Sep 2010 10:18:24 -0700 | From | Jesse Barnes <> | Subject | Re: MCP limit log messages, 2.6.36-rc4 |
| |
On Tue, 28 Sep 2010 10:34:21 -0600 Tim Gardner <tim.gardner@canonical.com> wrote:
> On 09/24/2010 10:18 AM, Jesse Barnes wrote: > > On Fri, 24 Sep 2010 06:46:45 +0800 > > Tim Gardner<tim.gardner@canonical.com> wrote: > >> Its just a debug hack which I wrote (that I mentioned in the first > >> email) so I could figure out why the driver was complaining. > > > > Oh sorry, missed that. An upstream patch for that would be welcome as > > well. > > > >> I'll be back from Asia by Monday and will give these patches a try. > > > > Great, as I said you may still see spurious "over power" conditions, > > but that's due to a bug in the i915 driver. > > > > With these 3 patches applied the MCP log message noise goes away. The > 4th patch (also applied) is the debug patch mentioned in my first email > (if you're still interested in it). This is on top of Linus tree at > 830c55a673537ca33ef4689fb5f20c2d66d98519 (plus some Ubuntu cruft). > > The only 'intel ips' messages left in the log are these: > > intel ips 0000:00:1f.6: Warning: CPU TDP doesn't match expected value > (found 25, expected 35) > intel ips 0000:00:1f.6: PCI INT C -> GSI 18 (level, low) -> IRQ 18 > intel ips 0000:00:1f.6: IPS driver initialized, MCP temp limit 95
All looks good.
Patch is a nice improvement too; please send it over to the x86 platform driver list and cc Matthew Garrett so he can apply it.
Thanks, -- Jesse Barnes, Intel Open Source Technology Center
| |