lkml.org 
[lkml]   [2010]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC v4 10/19] lpfc: Remove host_lock unlock() + lock() from lpfc_queuecommand()
    Date
    From: Nicholas Bellinger <nab@linux-iscsi.org>

    This patch removes the now legacy host_lock unlock() + lock() optimization
    from lpfc_scsi.c:lpfc_queuecommand(). This also includes setting the
    SHT->unlocked_qcmd=1 for host_lock less lpfc lpfc_queuecommand() operation.

    Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
    ---
    drivers/scsi/lpfc/lpfc_scsi.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
    index 2e51aa6..69fe31e 100644
    --- a/drivers/scsi/lpfc/lpfc_scsi.c
    +++ b/drivers/scsi/lpfc/lpfc_scsi.c
    @@ -3023,11 +3023,9 @@ lpfc_queuecommand(struct scsi_cmnd *cmnd, void (*done) (struct scsi_cmnd *))
    goto out_host_busy_free_buf;
    }
    if (phba->cfg_poll & ENABLE_FCP_RING_POLLING) {
    - spin_unlock(shost->host_lock);
    lpfc_sli_handle_fast_ring_event(phba,
    &phba->sli.ring[LPFC_FCP_RING], HA_R0RE_REQ);

    - spin_lock(shost->host_lock);
    if (phba->cfg_poll & DISABLE_FCP_RING_INT)
    lpfc_poll_rearm_timer(phba);
    }
    @@ -3723,6 +3721,7 @@ struct scsi_host_template lpfc_template = {
    .slave_destroy = lpfc_slave_destroy,
    .scan_finished = lpfc_scan_finished,
    .this_id = -1,
    + .unlocked_qcmd = 1,
    .sg_tablesize = LPFC_DEFAULT_SG_SEG_CNT,
    .cmd_per_lun = LPFC_CMD_PER_LUN,
    .use_clustering = ENABLE_CLUSTERING,
    @@ -3746,6 +3745,7 @@ struct scsi_host_template lpfc_vport_template = {
    .slave_destroy = lpfc_slave_destroy,
    .scan_finished = lpfc_scan_finished,
    .this_id = -1,
    + .unlocked_qcmd = 1,
    .sg_tablesize = LPFC_DEFAULT_SG_SEG_CNT,
    .cmd_per_lun = LPFC_CMD_PER_LUN,
    .use_clustering = ENABLE_CLUSTERING,
    --
    1.7.3


    \
     
     \ /
      Last update: 2010-09-28 04:11    [W:0.030 / U:4.428 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site