Messages in this thread | | | Date | Mon, 27 Sep 2010 13:01:50 +0200 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH 5/6] conntrack: export lsm context rather than internal secid via netlink |
| |
On 24/09/10 22:45, Eric Paris wrote: > @@ -172,4 +173,11 @@ enum ctattr_help { > }; > #define CTA_HELP_MAX (__CTA_HELP_MAX - 1) > > +enum ctattr_secctx { > + CTA_SECCTX_UNSPEC, > + CTA_SECCTX_NAME, > + __CTA_SECCTX_MAX > +}; > +#define CTA_SECCTX_MAX (__CTA_SECCTX_MAX - 1)
I guess that you have included this nest for consistency with CTA_HELP. My question: do you think that we'll include more attributes in that nest in the future? Otherwise, I would remove that nest and put CTA_SECCTX_NAME in the first level, since the nest would increase the message size.
| |