lkml.org 
[lkml]   [2010]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/5] mn10300: Get rid of set_fs(USER_DS) in sigframe setup
    Date
    From: Al Viro <viro@ftp.linux.org.uk>

    The set_fs(USER_DS) in the signal frame setup code really has no business
    being there; short of a serious kernel bug we should already have USER_DS at
    that point. It shouldn't have been done on x86 either...

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: David Howells <dhowells@redhat.com>
    ---

    arch/mn10300/kernel/signal.c | 4 ----
    1 files changed, 0 insertions(+), 4 deletions(-)


    diff --git a/arch/mn10300/kernel/signal.c b/arch/mn10300/kernel/signal.c
    index 5a2c004..ae36480 100644
    --- a/arch/mn10300/kernel/signal.c
    +++ b/arch/mn10300/kernel/signal.c
    @@ -333,8 +333,6 @@ static int setup_frame(int sig, struct k_sigaction *ka, sigset_t *set,
    regs->d0 = sig;
    regs->d1 = (unsigned long) &frame->sc;

    - set_fs(USER_DS);
    -
    /* the tracer may want to single-step inside the handler */
    if (test_thread_flag(TIF_SINGLESTEP))
    ptrace_notify(SIGTRAP);
    @@ -416,8 +414,6 @@ static int setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
    regs->d0 = sig;
    regs->d1 = (long) &frame->info;

    - set_fs(USER_DS);
    -
    /* the tracer may want to single-step inside the handler */
    if (test_thread_flag(TIF_SINGLESTEP))
    ptrace_notify(SIGTRAP);


    \
     
     \ /
      Last update: 2010-09-27 20:11    [W:0.022 / U:121.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site