lkml.org 
[lkml]   [2010]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC 09/12] xen/pvticketlock: Xen implementation for PV ticket locks
     On 09/26/2010 04:39 AM, Srivatsa Vaddagiri wrote:
    > On Fri, Jul 16, 2010 at 06:03:04PM -0700, Jeremy Fitzhardinge wrote:
    >> Replace the old Xen implementation of PV spinlocks with and implementation
    >> of xen_lock_spinning and xen_unlock_kick.
    > I see that the old implementation took care of a spinlock() call being
    > interrupted by another spinlock (in interrupt handler), by saving/restoring
    > old lock of interest. We don't seem to be doing that in this new version?
    > Won't that lead to loss of wakeup -> hang?

    No, interrupts are disabled while waiting to take the lock, so it isn't
    possible for an interrupt to come in. With the old-style locks it was
    reasonable to leave interrupts enabled while spinning, but with ticket
    locks it isn't.

    (I haven some prototype patches to implement nested spinning of ticket
    locks, by allowing the nested taker to steal the queue position of the
    outer lock-taker, and switch its ticket with a later one. But there's a
    fundamental problem with the idea: each lock taker needs to take a
    ticket. If you don't allow nesting, then the max amount of tickets
    needed = number of cpus-1; however, with nesting, the max number of
    tickets = ncpus * max-nesting-depth, so the size of the ticket type must
    be larger for a given number of cpus, or the max number of cpus must be
    reduced.)

    > Also are you planning to push this series into mainline sometime soon?
    >

    I was planning on sending it out for another round of review shortly; I
    got no comments on it at all the first time around.

    J


    \
     
     \ /
      Last update: 2010-09-27 20:11    [W:4.373 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site