lkml.org 
[lkml]   [2010]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: "blocked for more than 120 secs" --> a valid situation, how to prevent?
    On 2010-09-24 05:51, Mark Lord wrote:
    > On 10-09-23 10:53 PM, Mark Lord wrote:
    >> On 10-09-23 08:05 PM, Douglas Gilbert wrote:
    >>> Mark,
    >>> If you issued the SG_IO ioctl with a timeout of at
    >>> least 66 minutes (expressed in milliseconds) then
    >>> it looks like ata_scsi_queuecmd() has a problem.
    >> ..
    >>
    >> Mmm.. more like blk_execute_rq() perhaps.
    >> That's where the wait_for_completion(&wait) call is at.
    >>
    >> Perhaps I should change it to wait in smaller increments,
    >> so that the lockup detection doesn't trigger on it..
    > ..
    >
    > This patch (below) seems to work.
    >
    > Does this look kosher enough for me to roll it up
    > as a proper patch submission? Jens? Joel?

    Ideally it would be nice to just pass the info down that it should not
    complain, since waiting > 120 seconds (or whatever the timeout is set
    to) is expected by the caller in some cases.

    But your patch is simple enough and it gets the job done. I will queue
    it up for .37 if you send a properly formatted and signed-off-by
    version.

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:4.019 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site