lkml.org 
[lkml]   [2010]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/9] MIPS: Add a platform hook for swiotlb setup.
    On Fri, Sep 24, 2010 at 09:13:54AM -0700, David Daney wrote:

    > >>+#ifdef CONFIG_SWIOTLB
    > >>+ plat_swiotlb_setup();
    > >>+#endif
    > >
    > >We should avoid #ifdef's in function bodies. Why not defile an empty
    > >'inline' in the header above if CONFIG_SWIOTLB is not defined?
    > >
    >
    > Good idea. I will wait several days and collect any more feedback
    > and generate a new patch set.

    I'd also wait for a few more days so interested parties outside of the MIPS
    world will have a chance to comment.

    Ralf


    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:4.274 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site