[lkml]   [2010]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[19/68] drivers/net/cxgb3/cxgb3_main.c: prevent reading uninitialized stack memory
2.6.32-stable review patch.  If anyone has any objections, please let us know.

From: Dan Rosenberg <>

commit 49c37c0334a9b85d30ab3d6b5d1acb05ef2ef6de upstream.

Fixed formatting (tabs and line breaks).

The CHELSIO_GET_QSET_NUM device ioctl allows unprivileged users to read
4 bytes of uninitialized stack memory, because the "addr" member of the
ch_reg struct declared on the stack in cxgb_extension_ioctl() is not
altered or zeroed before being copied back to the user. This patch
takes care of it.

Signed-off-by: Dan Rosenberg <>
Signed-off-by: David S. Miller <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/net/cxgb3/cxgb3_main.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -2274,6 +2274,8 @@ static int cxgb_extension_ioctl(struct n
struct ch_reg edata;

+ memset(&edata, 0, sizeof(struct ch_reg));
edata.val = pi->nqsets;
if (copy_to_user(useraddr, &edata, sizeof(edata)))

 \ /
  Last update: 2010-09-27 20:09    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean