lkml.org 
[lkml]   [2010]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[19/68] drivers/net/cxgb3/cxgb3_main.c: prevent reading uninitialized stack memory
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Dan Rosenberg <drosenberg@vsecurity.com>

    commit 49c37c0334a9b85d30ab3d6b5d1acb05ef2ef6de upstream.

    Fixed formatting (tabs and line breaks).

    The CHELSIO_GET_QSET_NUM device ioctl allows unprivileged users to read
    4 bytes of uninitialized stack memory, because the "addr" member of the
    ch_reg struct declared on the stack in cxgb_extension_ioctl() is not
    altered or zeroed before being copied back to the user. This patch
    takes care of it.

    Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/cxgb3/cxgb3_main.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/cxgb3/cxgb3_main.c
    +++ b/drivers/net/cxgb3/cxgb3_main.c
    @@ -2274,6 +2274,8 @@ static int cxgb_extension_ioctl(struct n
    case CHELSIO_GET_QSET_NUM:{
    struct ch_reg edata;

    + memset(&edata, 0, sizeof(struct ch_reg));
    +
    edata.cmd = CHELSIO_GET_QSET_NUM;
    edata.val = pi->nqsets;
    if (copy_to_user(useraddr, &edata, sizeof(edata)))



    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:0.018 / U:2.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site