Messages in this thread | | | Date | Fri, 24 Sep 2010 10:21:46 -0700 | From | Jesse Barnes <> | Subject | Re: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg DeviceIDs |
| |
On Sat, 11 Sep 2010 10:57:06 +0200 Jean Delvare <khali@linux-fr.org> wrote:
> Hi Seth, > > On Fri, 10 Sep 2010 16:36:39 -0700, Seth Heasley wrote: > > This patch adds the LPC Controller DeviceIDs for the Intel Patsburg PCH. > > > > Signed-off-by: Seth Heasley <seth.heasley@intel.com> > > > > --- linux-2.6.35.4/include/linux/pci_ids.h.orig 2010-08-26 16:47:12.000000000 -0700 > > +++ linux-2.6.35.4/include/linux/pci_ids.h 2010-09-10 16:34:06.000000000 -0700 > > @@ -2423,6 +2423,7 @@ > > #define PCI_DEVICE_ID_INTEL_CPT_SMBUS 0x1c22 > > #define PCI_DEVICE_ID_INTEL_CPT_LPC_MIN 0x1c41 > > #define PCI_DEVICE_ID_INTEL_CPT_LPC_MAX 0x1c5f > > +#define PCI_DEVICE_ID_INTEL_PBG_LPC 0x1d40 > > #define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410 > > #define PCI_DEVICE_ID_INTEL_82801AA_1 0x2411 > > #define PCI_DEVICE_ID_INTEL_82801AA_3 0x2413 > > --- linux-2.6.35.4/arch/x86/pci/irq.c.orig 2010-08-26 16:47:12.000000000 -0700 > > +++ linux-2.6.35.4//arch/x86/pci/irq.c 2010-09-10 16:30:39.000000000 -0700 > > @@ -589,6 +589,7 @@ > > case PCI_DEVICE_ID_INTEL_ICH10_1: > > case PCI_DEVICE_ID_INTEL_ICH10_2: > > case PCI_DEVICE_ID_INTEL_ICH10_3: > > + case PCI_DEVICE_ID_INTEL_PBG_LPC: > > r->name = "PIIX/ICH"; > > r->get = pirq_piix_get; > > r->set = pirq_piix_set; > > Could Intel please stop using abbreviations for their chip names? If > the chip is named Patsburg then please use PATSBURG in the symbol names > too. MRST, PGB, etc. make me sick.
Agreed. Do you want to submit a rename patch for the existing stuff? You can do it on top of this one if you like, I'll put it into linux-next.
I guess this means more typing for you in future patches, Seth. :)
Thanks, -- Jesse Barnes, Intel Open Source Technology Center
| |