lkml.org 
[lkml]   [2010]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[78/80] sctp: Do not reset the packet during sctp_packet_config().
    2.6.35-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Vlad Yasevich <vladislav.yasevich@hp.com>

    commit 4bdab43323b459900578b200a4b8cf9713ac8fab upstream.

    sctp_packet_config() is called when getting the packet ready
    for appending of chunks. The function should not touch the
    current state, since it's possible to ping-pong between two
    transports when sending, and that can result packet corruption
    followed by skb overlfow crash.

    Reported-by: Thomas Dreibholz <dreibh@iem.uni-due.de>
    Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/sctp/output.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/net/sctp/output.c
    +++ b/net/sctp/output.c
    @@ -92,7 +92,6 @@ struct sctp_packet *sctp_packet_config(s
    SCTP_DEBUG_PRINTK("%s: packet:%p vtag:0x%x\n", __func__,
    packet, vtag);

    - sctp_packet_reset(packet);
    packet->vtag = vtag;

    if (ecn_capable && sctp_packet_empty(packet)) {



    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:0.024 / U:30.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site