lkml.org 
[lkml]   [2010]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 03/11] jump label: Base patch for jump label
    Date
    On Fri, 24 Sep 2010 04:10:06 am Jason Baron wrote:
    > @@ -2749,8 +2750,10 @@ SYSCALL_DEFINE3(init_module, void __user *, umod,
    > mod->symtab = mod->core_symtab;
    > mod->strtab = mod->core_strtab;
    > #endif
    > - module_free(mod, mod->module_init);
    > + init_code = mod->module_init;
    > mod->module_init = NULL;
    > + synchronize_rcu();
    > + module_free(mod, init_code);
    > mod->init_size = 0;
    > mod->init_text_size = 0;
    > mutex_unlock(&module_mutex);

    When a patch requires more lkml mails than it has lines, it needs a comment.

    But step back for a moment: what prompts the jump label update? Why isn't
    that simply done under the module lock, obviating any complexity?

    If you're frobbing kernel text all over the place, you probable want the
    module lock. You wouldn't be the first: perhaps we should rename that to
    kernel_text_lock...

    Apologies if that's a dumb question,
    Rusty.


    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:4.060 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site