lkml.org 
[lkml]   [2010]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] ASoC: Add max98088 CODEC driver
On Thu, Sep 23, 2010, Mark Brown wrote:
> On Wed, Sep 22, 2010 at 07:58:48PM -0700, Peter Hsiang wrote:
>
> > This patch adds the MAX98088 CODEC driver.
>
> > Signed-off-by: Peter Hsiang <peter.hsiang@maxim-ic.com>
>
> When you submitted the driver on the 31st of August my first comment in
> the review was:
>
> | The major issue with this is that the driver needs to be updated to
> | current ASoC versions - you should always be working against the trees
> | that are in linux-next for new drivers. For ASoC you should be looking
> | at:
>
> | git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
>
> Currently you should be looking at for-next or for-2.6.37, though the
> branch names will change as kernel development moves forward.

What is the git command line path/parameter for for-next or for-2.6.37?
Something equivalent to...
....pub/scm/linux/kernel/git/next/linux-next.git

Why do the files in git/broonie/sound-2.6.git look older than -next?
For example, it's missing soc-cache.c, and the codec drivers there
use the old I/O method. Same drivers in -next are newer and use the soc-cache.

>
> This must be rectified before the driver can be considered for inclusion
> in the kernel. As things stand the code will not compile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-09-27 20:09    [W:0.057 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site