lkml.org 
[lkml]   [2010]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] kmemleak: add unlikely() optimization to kmemleak_late_init
From
Date
On Wed, 2010-09-22 at 11:06 +0100, Catalin Marinas wrote:
> Davidlohr Bueso <dave@gnu.org> wrote:
> > kmemleak: add unlikely() optimization to kmemleak_late_init()
> >
> > Since there it is not very probable that kmemleak_disable() was called right after setting kmemleak_initialized, we could benefit from predicting it.
>
> The patch is correct and you can add my Acked-by but I don't really
> think it's worth. We save ~2 cycles during booting, no-one would ever
> notice.
>

Yeah, it's not a big performance booster, but IMHO it wouldn't hurt to
add it. Since you are the maintainer it's up to you if you include it
upstream.

Thanks,
Davidlohr



\
 
 \ /
  Last update: 2010-09-27 20:09    [W:0.380 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site