Messages in this thread | | | Subject | Re: [PATCH] kmemleak: add unlikely() optimization to kmemleak_late_init | From | Davidlohr Bueso <> | Date | Thu, 23 Sep 2010 10:05:12 -0400 |
| |
On Wed, 2010-09-22 at 11:06 +0100, Catalin Marinas wrote: > Davidlohr Bueso <dave@gnu.org> wrote: > > kmemleak: add unlikely() optimization to kmemleak_late_init() > > > > Since there it is not very probable that kmemleak_disable() was called right after setting kmemleak_initialized, we could benefit from predicting it. > > The patch is correct and you can add my Acked-by but I don't really > think it's worth. We save ~2 cycles during booting, no-one would ever > notice. >
Yeah, it's not a big performance booster, but IMHO it wouldn't hurt to add it. Since you are the maintainer it's up to you if you include it upstream.
Thanks, Davidlohr
| |