lkml.org 
[lkml]   [2010]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 0/2] Get and Set Feature Reports on HIDRAW (USB and Bluetooth)
    On 09/23/2010 12:25 PM, Ville Tervo wrote:
    > Hi Alan,
    >
    > On Mon, Aug 16, 2010 at 10:20:57PM +0200, ext Alan Ott wrote:
    >
    >> This is version 4. Built against 2.6.35+ revision 320b2b8de12698 .
    >>
    >
    > I gave a try to to this patch using your test tool [1] and very old BT
    > keyboard. I don't have anything else ATM to test with. Is there some BT hid
    > devices which support setting and getting features?
    >

    A keyboard is the only BT device I've used which has feature reports.

    > Shouldn't HIDIOCSFEATURE's bt version have similar wait as HIDIOCGFEATURE to
    > get report status back from the device? or is there even any status coming back
    > in successful case? Sorry I'm a newbie with HID and trying to understand how
    > this should work.
    >
    > Now it just returns num of send bytes even if the remote device returned some
    > error. Which one is the expected behavior?
    >

    I made it function the same as the existing hidp_output_raw_report().
    Nothing in net/bluetooth/hidp/core.c is acked at all. I'm not sure of
    the reasons.

    Jiri, Marcel, any ideas?

    > Other problem is that Get report is getting now handshake from set report.
    >
    >
    >

    Yeah, that makes sense. I hadn't considered the set_report failing. In
    that case, I guess it means we _must_ wait for an ack for sent packets.

    Anyone else agree or disagree?

    Alan.




    \
     
     \ /
      Last update: 2010-09-27 20:09    [W:2.130 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site