Messages in this thread | | | Date | Wed, 22 Sep 2010 22:39:39 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 2/2] siw: Add support for CRC32C offload instruction using libcrypto crc32c-intel |
| |
On 9/22/2010 10:30 PM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger<nab@linux-iscsi.org> > > This patch updates siw_create_qp() to check for the CONFIG_X86 + cpu_has_xmm4_2 > dependent use of the CRC32C instruction offload using libcrypto crc32c-intel.ko. > This patch will by default use crc32c-intel when available, and fall back to the > legacy slicing by 1x libcrypto crc32c.ko code when the instruction offload is not > availabe.
I don't think every caller should handle checks like this. The crypto layer should load the right driver instead and provide the best driver under a generic algorithm name.
Need CPUID module auto probing. I have an older patch that needs some fixes.
-Andi
| |