lkml.org 
[lkml]   [2010]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Add for_each_module iterator function
> > +void for_each_module(void (*op)(struct module *, void *arg), void *arg)
> > +{
> > + struct module *mod;
> > +
> > + preempt_disable();
>
> That wants rcu_read_lock()

Thanks. It was wrong anyways for the intended use case,
switched to module_mutex now.

BTW I think i copied this from somewhere else in module.c
Probably should be fixed there too.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2010-09-22 14:55    [W:0.232 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site