lkml.org 
[lkml]   [2010]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH #upstream-fixes] ahci: fix module refcount breakage introduced by libahci split
On 09/21/2010 09:32 AM, Michael Tokarev wrote:
> 21.09.2010 11:25, Tejun Heo wrote:
>> libata depends on scsi_host_template for module reference counting and
>> sht's should be owned by each low level driver. During libahci split,
>> the sht was left with libahci.ko leaving the actual low level drivers
>> not reference counted. This made ahci and ahci_platform always
>> unloadable even while they're being actively used.
>>
>> Fix it by defining AHCI_SHT() macro in ahci.h and defining a sht for
>> each low level ahci driver.
>>
>> stable: only applicable to 2.6.35.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
>> Cc: stable@kernel.org
>> ---
>> Michael, thanks a lot for spotting it and bearing with me.
> Um. All thanks goes to Pedro Francisco please, not to me -
> I just verified your patch on my system, it was Pedro who spotted
> and reported this. You may add my
>
> Tested-Off-By: Michael Tokarev <mjt@tls.msk.ru>
>
> , but not Reported-by... please ;)

Oh, right. Jeff, can you please adjust tags to

Reported-by: Pedro Francisco <pedrogfrancisco@gmail.com>
Tested-by: Michael Tokarev <mjt@tls.msk.ru>

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-09-21 10:19    [W:0.040 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site