Messages in this thread | | | Subject | Re: [RFC] led-class: always implement blinking | From | Johannes Berg <> | Date | Tue, 21 Sep 2010 21:51:52 +0200 |
| |
On Tue, 2010-09-21 at 21:48 +0200, Johannes Berg wrote:
> Well, this function gets assigned to led_cdev->blink_set(), which is a > function pointer that takes pass-by-reference arguments. The comment > there says: > > /* Activate hardware accelerated blink, delays are in > * miliseconds and if none is provided then a sensible default > * should be chosen. The call can adjust the timings if it can't > * match the values specified exactly. */ > int (*blink_set)(struct led_classdev *led_cdev, > unsigned long *delay_on, > unsigned long *delay_off); > > but the software implementation doesn't adjust the timings, of course. I > suppose the "adjust the timings" was also meant to update the values.
But I should update this and the other documentation ... and also provide a wrapper, because blink_set() is allowed to fail, in which software fallback should be used.
johannes
| |