lkml.org 
[lkml]   [2010]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/10] hugetlb: redefine hugepage copy functions
On Mon, Sep 20, 2010 at 01:15:44PM +0200, Andi Kleen wrote:
>
> >> +static void copy_gigantic_page(struct page *dst, struct page *src)
> >> +{
> >> + int i;
> >> + struct hstate *h = page_hstate(src);
> >> + struct page *dst_base = dst;
> >> + struct page *src_base = src;
> >> +
> >> + for (i = 0; i < pages_per_huge_page(h); ) {
> >> + cond_resched();
> >
> > Should this function not have a might_sleep() check too?
>
> cond_resched() implies might_sleep I believe. I think
> that answers the earlier question too becuse that function
> calls this.
>

You're right, cond_resched() calls might_sleep so the additional check
is redundant.

> /*
> >
> > Other than the removal of the might_sleep() check, this looks ok too.
>
> Can I assume an Ack?
>

Yes.

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab


\
 
 \ /
  Last update: 2010-09-20 13:21    [W:0.045 / U:17.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site