Messages in this thread | | | Date | Mon, 20 Sep 2010 13:15:44 +0200 | Subject | Re: [PATCH 03/10] hugetlb: redefine hugepage copy functions | From | "Andi Kleen" <> |
| |
>> +static void copy_gigantic_page(struct page *dst, struct page *src) >> +{ >> + int i; >> + struct hstate *h = page_hstate(src); >> + struct page *dst_base = dst; >> + struct page *src_base = src; >> + >> + for (i = 0; i < pages_per_huge_page(h); ) { >> + cond_resched(); > > Should this function not have a might_sleep() check too?
cond_resched() implies might_sleep I believe. I think that answers the earlier question too becuse that function calls this.
/* > > Other than the removal of the might_sleep() check, this looks ok too.
Can I assume an Ack?
Thanks, -Andi
| |