Messages in this thread | | | Subject | Re: [RFC 3/6] x86, NMI, Rename memory parity error to PCI SERR error | From | Huang Ying <> | Date | Tue, 21 Sep 2010 08:22:28 +0800 |
| |
On Mon, 2010-09-20 at 20:59 +0800, Borislav Petkov wrote: > From: Robert Richter <robert.richter@amd.com> > Date: Mon, Sep 20, 2010 at 10:00:10AM +0200 > > (adding Doug to CC) > > > On 18.09.10 20:20:35, Huang Ying wrote: > > > > If I am not wrong the only real functional change is to rip out the > > > > edac handler. So, just introduce the final names with your renaming in > > > > patch #1 (and maybe make a comment in the commit message or change > > > > patch order). > > > > > > If I merge the 1/6 and 3/6, can you suggest a patch subject, "Add symbol > > > definition for NMI magic constants and rename memory parity to PCI > > > SERR"? > > > > Yes, maybe we make the edac change a separate one. > > What is more, there are a bunch of edac drivers using the PCI SERR nmi > as a means to check for PCI errors so we shouldn't be removing it now, > should we?
After checking the source, I found in mem_parity_error (will renamed to pci_serr_error), edac_atomic_assert_error() is called, which increase edac_err_assert, edac_err_assert is used in edac_mc_assert_error_check_and_clear(), which is used in edac_mc_workq_function for memory error only, not for PCI errors.
Do we really need PCI SERR NMI for memory errors?
Best Regards, Huang Ying
| |