lkml.org 
[lkml]   [2010]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] Staging: comedi: fix EXPORT SYMBOL coding style issue in ni_labpc.c
On Sun, Sep 19, 2010 at 07:54:30PM +0100, Maurice Dawson wrote:
> This is a patch to the ni_labpc.c file that fixes up, EXPORT SYMBOL(foo) should immediately follow its function/variable
> warnings, found by the checkpatch.pl tool
>
> Signed-off-by: Maurice Dawson <mauricedawson2699@gmail.com>
> ---
> drivers/staging/comedi/drivers/ni_labpc.c | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c
> index 8d120cd..f18a8a7 100644
> --- a/drivers/staging/comedi/drivers/ni_labpc.c
> +++ b/drivers/staging/comedi/drivers/ni_labpc.c
> @@ -24,7 +24,7 @@ Driver: ni_labpc
> Description: National Instruments Lab-PC (& compatibles)
> Author: Frank Mori Hess <fmhess@users.sourceforge.net>
> Devices: [National Instruments] Lab-PC-1200 (labpc-1200),
> - Lab-PC-1200AI (labpc-1200ai), Lab-PC+ (lab-pc+), PCI-1200 (ni_labpc)
> + Lab-PC-1200AI(labpc-1200ai), Lab-PC + (lab-pc+), PCI-1200 (ni_labpc)
> Status: works

Why make this change?

>
> Tested with lab-pc-1200. For the older Lab-PC+, not all input ranges
> @@ -48,12 +48,12 @@ comedilib, use the comedi_calibrate program.
>
> Configuration options - ISA boards:
> [0] - I/O port base address
> -[1] - IRQ (optional, required for timed or externally triggered conversions)
> -[2] - DMA channel (optional)
> +[1] - IRQ(optional, required for timed or externally triggered conversions)
> +[2] - DMA channel(optional)

And these?

They have nothing to do with the patch description above, right?

>
> Configuration options - PCI boards:
> -[0] - bus (optional)
> -[1] - slot (optional)
> +[0] - bus(optional)
> +[1] - slot(optional)

Same here.

Care to redo this?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-09-21 02:03    [W:0.046 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site